asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fixed issues with Replication tests - Changed the way the lo...
Date Fri, 04 Nov 2016 06:17:52 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Fixed issues with Replication tests - Changed the way the log reader writes
the newValue - Fixed bug with creating recovery plan
......................................................................


Patch Set 1:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1334/1//COMMIT_MSG
Commit Message:

Line 7: Fixed issues with Replication tests
Add new line after the change title


https://asterix-gerrit.ics.uci.edu/#/c/1334/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/ClusterStateManager.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/ClusterStateManager.java:

Line 322:                     addActiveReplica(replica, partition, partitionRecoveryPlan);
If you leave it like this, all active replicas for that partitions will be requested to take
over the partition. You need to modify the addActiveReplica method and make it return a boolean.
It should return true if an active replica was added, otherwise false. Then, if the call to
addActiveReplica here returns true, you should break from the loop.


Line 365:                 partitionRecoveryPlan.get(replica).add(partition.getPartitionId());
return true;


Line 366:             }
return false;


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1334
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I204a41311012dc348d4d41ae8bf6ec8554ab3dc3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Akshay Manchale <akshayms91@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message