Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Sat, 15 Oct 2016 14:12:30 -0700
From: "Steven Jacobs (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
CC: Till Westmann <tillw@apache.org>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	Yingyi Bu <buyingyi@gmail.com>, Michael Carey <dtabass@gmail.com>,
	Michael Blow <mblow@apache.org>
Reply-To: sjaco002@ucr.edu
Subject: Change in asterixdb[master]: Enhanced Insert AQL
In-Reply-To: <gerrit.1473195422149.I65789d2a861d15232dd29156a6987d0635ec6c94@asterix-gerrit.ics.uci.edu>
References: <gerrit.1473195422149.I65789d2a861d15232dd29156a6987d0635ec6c94@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20161015211230.DE3B92420F6@unhygienix.ics.uci.edu>
archived-at: Sat, 15 Oct 2016 21:12:38 -0000

Steven Jacobs has posted comments on this change.

Change subject: Enhanced Insert AQL
......................................................................


Patch Set 19:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1150/19/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java:

Line 54: import org.eclipse.jetty.util.ArrayQueue;
> It's ArrayDeque.
Done


Line 88:         ArrayQueue<AbstractLogicalOperator> opStack = new ArrayQueue<>();
> It's ArrayDeque.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1150/19/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-with-bad-return/insert-with-bad-return.3.query.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/insert-with-bad-return/insert-with-bad-return.3.query.aql:

Line 34: ) returning 
> WS
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes