Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 59D84200BA5 for ; Wed, 5 Oct 2016 01:42:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5875A160ADC; Tue, 4 Oct 2016 23:42:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 976FC160ACC for ; Wed, 5 Oct 2016 01:42:16 +0200 (CEST) Received: (qmail 2277 invoked by uid 500); 4 Oct 2016 23:42:15 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 2268 invoked by uid 99); 4 Oct 2016 23:42:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Oct 2016 23:42:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 672611A5248 for ; Tue, 4 Oct 2016 23:42:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 7ZYcCYT8AJ58 for ; Tue, 4 Oct 2016 23:42:13 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F3DE35F2ED for ; Tue, 4 Oct 2016 23:42:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 0CE10241D60; Tue, 4 Oct 2016 16:42:12 -0700 (PDT) Date: Tue, 4 Oct 2016 16:42:11 -0700 From: "Till Westmann (Code Review)" To: Michael Blow CC: Jenkins Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc. X-Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2e6eca99f006745f567c0ab4bd060234a8c54d95 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20161004234212.0CE10241D60@unhygienix.ics.uci.edu> archived-at: Tue, 04 Oct 2016 23:42:17 -0000 Till Westmann has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. ...................................................................... Patch Set 4: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java: Line 52: break; Should we log when we start/quit the thread? Might be interesting to be able to see when that happens ... https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java: Line 677: void setRebindMetadataNode(boolean rebindMetadataNode); Do we need all those here? https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java: Line 58: public IMetadataNode getMetadataNode() { Does anybody use this? -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes