Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Sat, 1 Oct 2016 12:40:40 -0700
From: "abdullah alamoudi (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	Till Westmann <tillw@apache.org>, Yingyi Bu <buyingyi@gmail.com>,
	Michael Blow <mblow@apache.org>
Reply-To: bamousaa@gmail.com
Subject: Change in asterixdb[master]: ASTERIXDB-1642,ASTERIXDB-1657,ASTERIXDB-1658 Fix Task Failur...
In-Reply-To: <gerrit.1474545320208.I2ec2c798b704ca426d5937f22e6d2bd394a9095a@asterix-gerrit.ics.uci.edu>
References: <gerrit.1474545320208.I2ec2c798b704ca426d5937f22e6d2bd394a9095a@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20161001194040.7244F24207A@unhygienix.ics.uci.edu>
archived-at: Sat, 01 Oct 2016 19:40:45 -0000

abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1642,ASTERIXDB-1657,ASTERIXDB-1658 Fix Task Failure Handling
......................................................................


Patch Set 8:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1197/8/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java:

Line 103:         Task task = null;
> revert joblet and task declarations to where they used to be?
can't as we need to access them in the catch block.


Line 179:                 LOGGER.log(Level.WARNING, "Failure acquiring a joblet. Task has most likely been aborted", e);
> This if block is no longer needed?
theoretically, it is not needed because of the ordering of the work queues. but I would like to keep it just because I feel we didn't cover all the possible scenarios


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1197
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ec2c798b704ca426d5937f22e6d2bd394a9095a
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes