asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Remove ICCContext
Date Mon, 31 Oct 2016 16:33:28 GMT
Yingyi Bu has posted comments on this change.

Change subject: Remove ICCContext
......................................................................


Patch Set 5:

BTW, the method getIpAddressNodeNameMap in ClusterControllerService should be disabled.

Here is my proposal.  If we want to do the refactoring, we probably should refactor the CC/NC
service in a way that we do not remove ICCContext and ServerContext, but factor out more things
into the two contexts. In principle, XXXWorks should only be able to see the contexts but
not the service, such that they cannot call start() and stop() of the service. In this way,
we can simplify the CC/NC service implementations and future extensions by separating out
low-level details.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6a769741f14e91bcd4b970b4a022c0a453d380
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message