asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Extract IPCIs out of ClusterControllerService
Date Sun, 30 Oct 2016 17:44:43 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Extract IPCIs out of ClusterControllerService
......................................................................


Patch Set 4:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1325/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java:

Line 147:                             @Override
> is the code formatted?  It seems there should be lines between methods.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1325/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/HyracksClientInterfaceIPCI.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/HyracksClientInterfaceIPCI.java:

Line 46: class HyracksClientInterfaceIPCI implements IIPCI {
> Remove "Hyracks" from the class name?
Done


Line 64:                 } catch (IPCException e) {
> Pls address this?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1325/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java:

Line 511:     private final class NodeControllerIPCI implements IIPCI {
> Can this IPCI be moved out too?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1325
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I403e61cc054a860bef6a71fa04393f4d9c368b36
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message