asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add result location HTTP API.
Date Fri, 21 Oct 2016 17:15:35 GMT
Michael Blow has posted comments on this change.

Change subject: Add result location HTTP API.
......................................................................


Patch Set 3:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1178/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java:

Line 47: public class QueryResultLocationsAPIServlets extends HttpServlet {
same comment as patch 2 (/Servlets/Servlet/)


Line 119:             GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, e.getMessage(), e);
e.getMessage() is often not useful for many types of exception.  Given that the exception
itself is also being logged, perhaps just some message "Unexpected exception"?


https://asterix-gerrit.ics.uci.edu/#/c/1178/3/asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.1.rlocation.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/api/result_location_1/result_location_1.1.rlocation.aql:

Line 25:  
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet <wael.y.k@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Wail Alkowaileet <wael.y.k@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message