asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1701: Fix log file boundry check
Date Fri, 21 Oct 2016 09:02:08 GMT
Murtadha Hubail has posted comments on this change.

Change subject: ASTERIXDB-1701: Fix log file boundry check
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1306/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java:

Line 160:         // Make sure the log will not exceed the log file size
> I see the bug now. It's true now that a page could reach past the end of th
Not necessarily.

The log file offset is calculated based on the current appendLSN. Since the append LSN has
already passed the log file boundary, the modulo function in getLogFileOffset method will
return a small offset, causing the if statement for the log file boundary check to be false.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1306
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I538a8b931f3d50a00b092f218887a9731d14e235
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message