asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add Checkpoint Test
Date Thu, 20 Oct 2016 02:28:29 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Add Checkpoint Test
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
File asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java:

Line 129:             ExecutionTestUtil.setUp(cleanupOnStart,
> Is this just to speed things up (i.e. allowing HDFS test cluster to be skip
Yes.


https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java:

Line 149:                 if (initialLowWaterMarkFileId == currentLowWaterMarkLogFileId) {
> What should happen here if the condition is not true? Isn't it expected as 
Even though there is no checkpoint yet, there is a tiny chance (depending on the dataset memory
budget configuration) that the dataset is flushed right at the beginning of the second log
file, so the lowWaterMarkLSN would be in the second log file. In that case, this part of the
test case will be skipped but the log file deletion part will still be tested.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message