asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add Checkpoint Test
Date Thu, 20 Oct 2016 02:16:49 GMT
Ian Maxon has posted comments on this change.

Change subject: Add Checkpoint Test
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Just a couple questions, otherwise looks great to me.

https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
File asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java:

Line 129:             ExecutionTestUtil.setUp(cleanupOnStart,
Is this just to speed things up (i.e. allowing HDFS test cluster to be skipped)?


https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java:

Line 149:                 if (initialLowWaterMarkFileId == currentLowWaterMarkLogFileId) {
What should happen here if the condition is not true? Isn't it expected as a consequence of
not having a checkpoint yet?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message