asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <>
Subject Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...
Date Wed, 12 Oct 2016 23:55:45 GMT
Steven Jacobs has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure function calls

Patch Set 12:

File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/

Line 190:         if (annotation != null && !((Boolean) annotation)) {
> OK, can you give me an example that moving a non-pure call is fine?
In this case, it is actually deciding whether the field access can be pushed through op2.
This is okay even when op2 is nonPure.
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/

Line 668:     //Get Variables used by afterSelectRefs that were created before the datasource
> But retainInput changes the semantics?
I don't quite understand this question. This method makes it so that, in the select case,
if variables are used after the select, they are retained after the select.
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/

Line 80:     ILogicalExpression[] getConstantExpressions();
> Does the constant mean a real "constant" in the query, or it means a relati
Constants will only be "real constants" after this change. Previous changes allowed for other
cases, but we will not allow for these anymore.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Michael Blow <>
Gerrit-Reviewer: Preston Carman <>
Gerrit-Reviewer: Steven Jacobs <>
Gerrit-Reviewer: Taewoo Kim <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-HasComments: Yes

View raw message