asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Tests for ASTERIXDB-1636
Date Wed, 05 Oct 2016 20:56:43 GMT
Taewoo Kim has posted comments on this change.

Change subject: Tests for ASTERIXDB-1636
......................................................................


Patch Set 2:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1248/2/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixRestartIT.java
File asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixRestartIT.java:

Line 37: public class AsterixRestartIT {
Please put some description of the class here - what this is for.


https://asterix-gerrit.ics.uci.edu/#/c/1248/2/asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.1.ddl.aql
File asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.1.ddl.aql:

Line 1: drop dataverse twitter if exists;
#1. We normally put the license header to each test, right?

#2. Can we say some description here?


https://asterix-gerrit.ics.uci.edu/#/c/1248/2/asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.9.sleep.aql
File asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.9.sleep.aql:

Line 25:  */
Is this correct description?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1248
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1521f1d53121b67677778ac123e49e731932c85
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-HasComments: Yes

Mime
View raw message