asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Date Tue, 04 Oct 2016 23:42:11 GMT
Till Westmann has posted comments on this change.

Change subject: Wait For Metadata Registration Before Active, Etc.
......................................................................


Patch Set 4:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java:

Line 52:                 break;
Should we log when we start/quit the thread? Might be interesting to be able to see when that
happens ...


https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java:

Line 677:     void setRebindMetadataNode(boolean rebindMetadataNode);
Do we need all those here?


https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java:

Line 58:     public IMetadataNode getMetadataNode() {
Does anybody use this?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1247
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message