asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix potential hanging in op.initialize().
Date Tue, 04 Oct 2016 07:16:38 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Fix potential hanging in op.initialize().
......................................................................


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1243/3/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java
File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java:

Line 134:         // should be executed.
let's fix the comment and then:
instead of using atomic integers, lets' use mutable static  int[]s where the size = the number
of partitions. we can set the int[]s before creating the jobs and then starts the job, each
task will then work on its own createPushRuntime[partition], openCloseCounter[partition],
and initializeCounter[partition].

then in succeed(), we can check that the values in all of the counters == 0. that is more
precise and would tell us if exactly what we expect is happening.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1243
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message