Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3132F200B9F for ; Tue, 27 Sep 2016 05:21:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3003E160AE3; Tue, 27 Sep 2016 03:21:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7420D160ACA for ; Tue, 27 Sep 2016 05:21:56 +0200 (CEST) Received: (qmail 99861 invoked by uid 500); 27 Sep 2016 03:21:55 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 99852 invoked by uid 99); 27 Sep 2016 03:21:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Sep 2016 03:21:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0DDAEC1C21 for ; Tue, 27 Sep 2016 03:21:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id E6BNDCuHwCZz for ; Tue, 27 Sep 2016 03:21:52 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTP id 1774E5FC22 for ; Tue, 27 Sep 2016 03:21:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id B2AB7241099; Mon, 26 Sep 2016 20:21:51 -0700 (PDT) Date: Mon, 26 Sep 2016 20:21:51 -0700 From: "Till Westmann (Code Review)" To: abdullah alamoudi CC: Jenkins , Yingyi Bu , Michael Blow Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: ASTERIXDB-1642,ASTERIXDB-1657,ASTERIXDB-1658 Fix Task Failur... X-Gerrit-Change-Id: I2ec2c798b704ca426d5937f22e6d2bd394a9095a X-Gerrit-ChangeURL: X-Gerrit-Commit: f515e0f01684a7bae9bd49d22fd9ad55a188fd76 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160927032151.B2AB7241099@unhygienix.ics.uci.edu> archived-at: Tue, 27 Sep 2016 03:21:57 -0000 Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1642,ASTERIXDB-1657,ASTERIXDB-1658 Fix Task Failure Handling ...................................................................... Patch Set 6: Code-Review+1 (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1197/6/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/scheduler/JobScheduler.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/scheduler/JobScheduler.java: Line 633: * - Activity Cluster that owns this Task fix comment as well https://asterix-gerrit.ics.uci.edu/#/c/1197/6/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Joblet.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Joblet.java: Line 106: private volatile Thread taskInitializationThreads; Why is the "threads" instead of "thread"? https://asterix-gerrit.ics.uci.edu/#/c/1197/6/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/AbortTasksWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/AbortTasksWork.java: Line 53: } Why do this in the constructor? Isn't that risky? https://asterix-gerrit.ics.uci.edu/#/c/1197/6/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java: Line 205: throw new NullPointerException("Joblet was not found. This job was most likely aborted!!"); Is this is somewhat expected, I think that we shouldn't throw an NPE, also the error messages are better without the exclamation marks. https://asterix-gerrit.ics.uci.edu/#/c/1197/6/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractMultiNCIntegrationTest.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/AbstractMultiNCIntegrationTest.java: Line 73: outputFiles = new ArrayList();; Just remove the 2nd semicolon? -- To view, visit https://asterix-gerrit.ics.uci.edu/1197 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec2c798b704ca426d5937f22e6d2bd394a9095a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes