Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4B385200B80 for ; Wed, 14 Sep 2016 21:37:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 48E11160AD4; Wed, 14 Sep 2016 19:37:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 729F8160AB3 for ; Wed, 14 Sep 2016 21:36:59 +0200 (CEST) Received: (qmail 16553 invoked by uid 500); 14 Sep 2016 19:36:58 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 16537 invoked by uid 99); 14 Sep 2016 19:36:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Sep 2016 19:36:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 44367C0E36 for ; Wed, 14 Sep 2016 19:36:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.126 X-Spam-Level: ** X-Spam-Status: No, score=2.126 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pIHjIySMa7Bl for ; Wed, 14 Sep 2016 19:36:56 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTP id C9B6B5F246 for ; Wed, 14 Sep 2016 19:36:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 639A4240C2C; Wed, 14 Sep 2016 12:36:55 -0700 (PDT) Date: Wed, 14 Sep 2016 12:36:55 -0700 From: "Steven Jacobs (Code Review)" CC: Till Westmann , abdullah alamoudi , Jenkins , Yingyi Bu Reply-To: sjaco002@ucr.edu X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Enhanced Insert AQL Added "return records" and "returning [f... X-Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 X-Gerrit-ChangeURL: X-Gerrit-Commit: 536a1616110c9fdc87329edfdd799fa3ae31c5a1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160914193655.639A4240C2C@unhygienix.ics.uci.edu> archived-at: Wed, 14 Sep 2016 19:37:00 -0000 Steven Jacobs has posted comments on this change. Change subject: Enhanced Insert AQL Added "return records" and "returning [fieldName]" "return records" returns to the user all records that were inserted "returning [fieldName]" returns only the valuse inserted for [fieldName] Allow commits to be non-sink operators (con ...................................................................... Patch Set 8: (19 comments) Addressed comments https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java: Line 49: * @param resultSetIdCounter > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/CommitOperator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/CommitOperator.java: Line 41: primaryKeyLogicalVars = new ArrayList(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java: Line 98: * pattern match: commit insert assign > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java: Line 78: AssignOperator upsertFlagAssign = null; > MAJOR SonarQube violation: Done Line 81: IndexInsertDeleteUpsertOperator indexInsertDeleteUpsertOperator = (IndexInsertDeleteUpsertOperator) descendantOp; > MAJOR SonarQube violation: Done Line 132: if (descendantOp.getInputs().size() < 1) { > MAJOR SonarQube violation: Done Line 143: List primaryKeyLogicalVars = new ArrayList(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java: Line 641: List> varRefList = new ArrayList>(); > MAJOR SonarQube violation: Done Line 655: List assignVars = new ArrayList(); > MAJOR SonarQube violation: Done Line 656: List> expressions = new ArrayList>(); > MAJOR SonarQube violation: Done Line 657: Mutable nameRef = new MutableObject(new ConstantExpression( > MAJOR SonarQube violation: Done Line 665: varRefList = new ArrayList>(); > MAJOR SonarQube violation: Done Line 666: Mutable mVarRef = new MutableObject( > MAJOR SonarQube violation: Done Line 678: // Retrieve the Output RecordType (if any) and store it on > MAJOR SonarQube violation: Done Line 679: // the DistributeResultOperator > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java: Line 36: private static final String FEED_EXTENSION_NAME = "Feed"; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java: Line 32: this.inbox = new LinkedBlockingQueue(); > MAJOR SonarQube violation: Done Line 43: ActiveLifecycleEvent e = null; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUUID.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUUID.java: Line 42: protected static final char[] CHARS; > CRITICAL SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes