Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D2963200B6B for ; Fri, 9 Sep 2016 18:39:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D1279160AC2; Fri, 9 Sep 2016 16:39:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 22035160AA3 for ; Fri, 9 Sep 2016 18:39:13 +0200 (CEST) Received: (qmail 85037 invoked by uid 500); 9 Sep 2016 16:39:13 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 85011 invoked by uid 99); 9 Sep 2016 16:39:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Sep 2016 16:39:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EC7CCC0361 for ; Fri, 9 Sep 2016 16:39:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id JpwXMSg_hZRV for ; Fri, 9 Sep 2016 16:39:11 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTP id 5E26B5FBD0 for ; Fri, 9 Sep 2016 16:39:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id BFFC3241DA2; Fri, 9 Sep 2016 09:39:09 -0700 (PDT) Date: Fri, 9 Sep 2016 09:39:09 -0700 From: "Taewoo Kim (Code Review)" To: Wenhai Li CC: Jenkins , Yingyi Bu , Yingyi Bu , Taewoo Kim , Chen Li , Jianfeng Jia , Till Westmann Reply-To: wangsaeu@yahoo.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin. X-Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad X-Gerrit-ChangeURL: X-Gerrit-Commit: 232ce2308198a3d7c6a9c009dae7cf00a18c7a2d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160909163909.BFFC3241DA2@unhygienix.ics.uci.edu> archived-at: Fri, 09 Sep 2016 16:39:15 -0000 Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin. ...................................................................... Patch Set 10: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1119/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java: Line 208: || op.getOperatorTag().equals(LogicalOperatorTag.LEFT_OUTER_UNNEST_MAP)) { Two if conditions can be the same check - either equals or ==. Please unify them. -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes