Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D4573200B78 for ; Fri, 2 Sep 2016 22:36:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D1CF5160AAE; Fri, 2 Sep 2016 20:36:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 244F4160A8C for ; Fri, 2 Sep 2016 22:36:58 +0200 (CEST) Received: (qmail 53248 invoked by uid 500); 2 Sep 2016 20:36:58 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 53239 invoked by uid 99); 2 Sep 2016 20:36:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2016 20:36:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F0D40188590 for ; Fri, 2 Sep 2016 20:36:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id h3xTdbf1U8Ge for ; Fri, 2 Sep 2016 20:36:57 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A614F5F1F3 for ; Fri, 2 Sep 2016 20:36:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 0F833242056; Fri, 2 Sep 2016 13:36:56 -0700 (PDT) Date: Fri, 2 Sep 2016 13:36:56 -0700 From: "Chen Li (Code Review)" To: Wenhai Li CC: Jenkins , Taewoo Kim Reply-To: chenli@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi... X-Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc X-Gerrit-ChangeURL: X-Gerrit-Commit: 4411f29cb24d33d0fc57b377089f315f7471328f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160902203656.0F833242056@unhygienix.ics.uci.edu> archived-at: Fri, 02 Sep 2016 20:37:00 -0000 Chen Li has posted comments on this change. Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin testCases. ...................................................................... Patch Set 5: (2 comments) @Wenhai: In this patch, can you give a high-level description of the changes, including the symptom, bug source, and the fix? https://asterix-gerrit.ics.uci.edu/#/c/1076/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java: Line 252: fuzzy.add(new FuzzyJoinRule()); Rename "fuzzy" to "fuzzyRules"? Line 253: // Embedding the prefix join instead of ~= cause the newly subplan derived from the AggregateOp->NTSOp I am not quite following this comment. Can you try to rephrase it to make it more clear? -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Wenhai Li Gerrit-HasComments: Yes