asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <>
Subject Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator
Date Thu, 29 Sep 2016 22:24:48 GMT
Taewoo Kim has posted comments on this change.

Change subject: Index-only plan step 2: Added SplitOperator

Patch Set 10:


@Jianfeng: thanks for the comments. Regarding your first comments, I think we may need to
patch first.
File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/

Line 32:     private Mutable<ILogicalExpression> branchingExpression;
> Can this one be Immutable? we should not change the expression.
File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/

Line 73:             builder.addTargetEdge(i, sma, pipelineOutputIndex++);
> isn't this `pipelineOutputIndex` == `i`?

Line 91:                 private final boolean[] isOpen = new boolean[numberOfNonMaterializedOutputs];
> where does this `numberOfNonMaterializedOutputs` come from?
Initialized in the super class - AbstractReplicateOperatorDescriptor. For this split operator,
the number of output is the same as numberOfNonMaterializedOutputs.

Line 111:                     builders = new ArrayTupleBuilder[numberOfNonMaterializedOutputs];
> this builder seems not be used

Line 112:                     builderDatas = new GrowableArray[numberOfNonMaterializedOutputs];
> ditto
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/base/

Line 70:         for (boolean flag : outputMaterializationFlags) {
> I'm confused by the original code. Based on the outputMaterializationFlags 
This was introduced by
So, you may check there. Frankly, I'm not understanding the code 100% for this part.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Jianfeng Jia <>
Gerrit-Reviewer: Taewoo Kim <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-HasComments: Yes

View raw message