asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <>
Subject Change in asterixdb[master]: Fixes for ASTERIXDB-1636
Date Thu, 29 Sep 2016 21:26:20 GMT
Hello Jianfeng Jia, Jenkins,

I'd like you to reexamine a change.  Please visit

to look at the new patch set (#5).

Change subject: Fixes for ASTERIXDB-1636

Fixes for ASTERIXDB-1636

The index of the tuple field for filters from SecondaryIndexOperationsHelper and AqlMetadataProvider
differed. The one in AqlMetadataProvider was wrong, as it was attempting to take into account
presence of a partitioning field in the incoming tuple, which is not there in the case of

There was also an issue where on merge, for components with a filter page but no min/max,
the merge
would fail. I fixed this by skipping over null entries while getting the min/max of merging

Finally, there was a very silly error in LSMComponentFilterManager which was causing the filter
to appear as blank, because the page was being pinned with the wrong argument. That is also

Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/
M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/
M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/
3 files changed, 22 insertions(+), 18 deletions(-)

  git pull ssh:// refs/changes/05/1205/5
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Jianfeng Jia <>
Gerrit-Reviewer: Taewoo Kim <>

View raw message