asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Updated DeletableFrameTupleAppender to support reusing index...
Date Wed, 28 Sep 2016 23:22:34 GMT
Taewoo Kim has posted comments on this change.

Change subject: Updated DeletableFrameTupleAppender to support reusing index slots.
......................................................................


Patch Set 2:

Before going into the detail, I would like to add my two-cent thoughts since I'm little bit
worried about extra space usage per each slot.  

It seems like this DeletableFrameTupleAppender is used in heap sort. I think changing this
affects the performance. Can you do some performance test to show that this change doesn't
degrade the performance for general heap-sort?

Also, if it affects the performance, can we extend this class to create a new appender that
includes your design here?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1214
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05cda3360cc503bf847aeca5998be06f1f7d3c15
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: No

Mime
View raw message