asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator
Date Tue, 27 Sep 2016 20:24:46 GMT
Taewoo Kim has posted comments on this change.

Change subject: Index-only plan step 2: Added SplitOperator
......................................................................


Patch Set 5:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1196/5/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SplitOperator.java
File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SplitOperator.java:

Line 28:  * @author waans11
> Could we avoid author tags? Most Apache projects don't use them and I think
Sure. I am not sure why this was added. :-)


https://asterix-gerrit.ics.uci.edu/#/c/1196/5/hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
File hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml:

Line 76:         <artifactId>algebricks-data</artifactId>
> I think that Hyracks should not depend on Algebricks.
Let me think more. Thanks.


Line 77:         <version>0.2.18-SNAPSHOT</version>
> We should not depend on a explicit version.
It was done by Eclipse. :-) Will remove it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1196
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message