asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1652: fix dataverse.function(...) to check the exi...
Date Wed, 21 Sep 2016 18:45:14 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1652: fix dataverse.function(...) to check the existence of the
dataverse.
......................................................................


Patch Set 4:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1192/4/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml:

Line 7006:         <expected-error>Dataverse test cannot be found for function call
test.length!</expected-error>
The error message seems confusing. Can we improve that easily?


https://asterix-gerrit.ics.uci.edu/#/c/1192/4/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java:

Line 67:      * Retrieve stored functions (from CREATE FUNCTION statements) that has been
used in an expression.
s/has/have/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1192
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7779db56f540fdd645bb85c769baeaa37f620a0d
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message