asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1631: let TypeComputeUitls handle input type ANY p...
Date Wed, 21 Sep 2016 01:27:28 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1631: let TypeComputeUitls handle input type ANY properly.
......................................................................


Patch Set 2:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1191/2//COMMIT_MSG
Commit Message:

Line 7: ASTERIXDB-1631: let TypeComputeUitls handle input type ANY properly.
s/TypeComputeUitls/TypeComputeUtils/


https://asterix-gerrit.ics.uci.edu/#/c/1191/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java:

Line 127:             } else if (inputTypeTag == ATypeTag.ANY) {
Could we switch on inputType.getTypeTag()?


https://asterix-gerrit.ics.uci.edu/#/c/1191/2/asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java
File asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java:

Line 105:         IAType resultType = instance.computeType(mockExpr, mockTypeEnv, mockMetadataProvider);
Running through the tests a saw a few result types, that were UNION types with more than one
MISSING in the UNION. Should we file an issue for those (and/or test for those here)?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1191
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b3f0e9d9b4ddd9280e06f72a5ca30aa776315d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message