asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multi...
Date Tue, 20 Sep 2016 01:17:14 GMT
Taewoo Kim has posted comments on this change.

Change subject: ASTERIXDB-1081, ASTERIXDB-1086, ASTERIXDB-1246: proper multiple plan paths
handling
......................................................................


Patch Set 17:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1073/17/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/IntroduceProjectsRule.java
File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/IntroduceProjectsRule.java:

Line 102:         for (int i = 0; i < op.getInputs().size(); i++) {
> for(Mutable<ILogicalOperator> inputOpRef : op.getInputs){
Done


https://asterix-gerrit.ics.uci.edu/#/c/1073/17/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveRedundantGroupByDecorVarsRule.java
File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveRedundantGroupByDecorVarsRule.java:

Line 47:     protected Set<LogicalVariable> usedVars = new HashSet<>();
> private?
Done


Line 50:     public boolean rewritePost(Mutable<ILogicalOperator> opRef, IOptimizationContext
context) {
> remove rewritePost because it is the same as that in IAlgebraicRewriteRule.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1073/17/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveUnusedAssignAndAggregateRule.java
File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveUnusedAssignAndAggregateRule.java:

Line 57:     // and GROUP operators.
> Make class members private.
Done


Line 323:         boolean assignOpFound = false;
> assignOpFound --> targetOpFound
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69e055572f024f28a857d4e64916b4806e63c083
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message