asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wenhai Li (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin.
Date Fri, 16 Sep 2016 03:08:34 GMT
Wenhai Li has posted comments on this change.

Change subject: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin.
......................................................................


Patch Set 11:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1119/11//COMMIT_MSG
Commit Message:

Line 10: 2. Disable the join branch pruning in case of unnestmap following datasourcescan.
> Can you add more explanation on " unnestmap following datasourcescan"?  
Done


Line 11: 
> Remove local commit history in the commit message.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1119/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java:

Line 159:         for (int i = 0; i < joinOp.getInputs().size(); i++) {
> Move the unnest-map gathering/check to line 189. 
This is really more general. Let's try it later.


Line 188:         // The pre-plan is (broadcast B and index search on A on each A.a ~= B.b)
join B on A.a = B.b
> Can you add the explanation as a comment in the code?  Particularly, explai
Done


https://asterix-gerrit.ics.uci.edu/#/c/1119/11/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql:

Line 19: 
> Can you a description of this test? What it is intended for? And the expect
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li <lwhaymail@yahoo.com>
Gerrit-Reviewer: Chen Li <chenli@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Wenhai Li <lwhaymail@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-HasComments: Yes

Mime
View raw message