asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Enhanced Insert AQL Added "return records" and "returning [f...
Date Wed, 14 Sep 2016 19:36:55 GMT
Steven Jacobs has posted comments on this change.

Change subject: Enhanced Insert AQL Added "return records" and "returning [fieldName]" "return
records" returns to the user all records that were inserted "returning [fieldName]" returns
only the valuse inserted for [fieldName] Allow commits to be non-sink operators (con
......................................................................


Patch Set 8:

(19 comments)

Addressed comments

https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java:

Line 49:      * @param resultSetIdCounter 
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/CommitOperator.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/CommitOperator.java:

Line 41:         primaryKeyLogicalVars = new ArrayList<LogicalVariable>();
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java:

Line 98:                  * pattern match: commit insert assign 
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java:

Line 78:         AssignOperator upsertFlagAssign = null;
> MAJOR SonarQube violation:
Done


Line 81:                 IndexInsertDeleteUpsertOperator indexInsertDeleteUpsertOperator =
(IndexInsertDeleteUpsertOperator) descendantOp;
> MAJOR SonarQube violation:
Done


Line 132:             if (descendantOp.getInputs().size() < 1) {
> MAJOR SonarQube violation:
Done


Line 143:         List<LogicalVariable> primaryKeyLogicalVars = new ArrayList<LogicalVariable>();
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

Line 641:             List<Mutable<ILogicalExpression>> varRefList = new ArrayList<Mutable<ILogicalExpression>>();
> MAJOR SonarQube violation:
Done


Line 655:                 List<LogicalVariable> assignVars = new ArrayList<LogicalVariable>();
> MAJOR SonarQube violation:
Done


Line 656:                 List<Mutable<ILogicalExpression>> expressions = new
ArrayList<Mutable<ILogicalExpression>>();
> MAJOR SonarQube violation:
Done


Line 657:                 Mutable<ILogicalExpression> nameRef = new MutableObject<ILogicalExpression>(new
ConstantExpression(
> MAJOR SonarQube violation:
Done


Line 665:                 varRefList = new ArrayList<Mutable<ILogicalExpression>>();
> MAJOR SonarQube violation:
Done


Line 666:                 Mutable<ILogicalExpression> mVarRef = new MutableObject<ILogicalExpression>(
> MAJOR SonarQube violation:
Done


Line 678:             // Retrieve the Output RecordType (if any) and store it on  
> MAJOR SonarQube violation:
Done


Line 679:             // the DistributeResultOperator     
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java:

Line 36:     private static final String FEED_EXTENSION_NAME = "Feed";
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ActiveLifecycleEventSubscriber.java:

Line 32:         this.inbox = new LinkedBlockingQueue<ActiveLifecycleEvent>();
> MAJOR SonarQube violation:
Done


Line 43:         ActiveLifecycleEvent e = null;
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1150/8/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUUID.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUUID.java:

Line 42:     protected static final char[] CHARS;
> CRITICAL SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1150
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message