asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianfeng Jia (Code Review)" <>
Subject Change in asterixdb[master]: Adding a new 101 tutorial for SQL++.
Date Wed, 14 Sep 2016 05:36:56 GMT
Jianfeng Jia has posted comments on this change.

Change subject: Adding a new 101 tutorial for SQL++.

Patch Set 1:


Looks good to me. 

All comments are more about the SQL++ syntax itself than the contents. Some syntax is a little
hard for me to follow at the first glance.  Don't know if it worth explaining for newbies
like me.
File asterixdb/asterix-doc/src/site/markdown/sqlpp/

Line 87:         DROP DATAVERSE TinySocial IF EXISTS;
Are all reserved keywords required to be uppercase?

Line 92:             screenName: string,
Can these type tags be uppercase?

Line 194:         SELECT VALUE ds FROM Metadata.`Dataset` ds;
why there are two `ds` here?

Line 195:         SELECT VALUE ix FROM Metadata.`Index` ix;
why are we using backquote?

Line 434:         SELECT AS uname, msg.message AS message
why we don't have VALUE if accessing the field?

Line 532:         { "uname": "IsbelDull", "message": " like t-mobile its platform is mind-blowing"
what would be the result be if the select without `AS` ? 

SELECT , msg.message

Line 798: USE TinySocial;
this line should be indented?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b4947b928f301e8fdca8522d9a9f1e6a772cb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Carey <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Jianfeng Jia <>
Gerrit-Reviewer: Taewoo Kim <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-HasComments: Yes

View raw message