asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Small Cleanup Towards Fixing LifeCycle Issues
Date Sun, 11 Sep 2016 06:13:40 GMT
Till Westmann has posted comments on this change.

Change subject: Small Cleanup Towards Fixing LifeCycle Issues
......................................................................


Patch Set 4:

(3 comments)

Looks generally good, but I think that we need to get closure on the 3 comments.

https://asterix-gerrit.ics.uci.edu/#/c/1148/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java:

Line 61:         ncs.sendApplicationMessageToCC(JavaSerializationUtils.serialize(message),
null);
Why is the callback mechanism removed? Did you discuss with Murtadha?


https://asterix-gerrit.ics.uci.edu/#/c/1148/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycle.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycle.java:

Line 39: public class DatasetLifecycle implements Comparable<DatasetLifecycle> {
The name is confusing. An object lifecycle is the time between creation and destruction of
an object. I do not think that this object represents this time for a DataSet object. 

It seems that this object extends DataSetInfo with some associated objects, the OpTracker
and the VirtualBufferCaches. Maybe we should implement it as an extension to DataSetInfo that's
called "DataSetExtendedInfo"? Or roll the references to the associated objects into DatasetInfo?


https://asterix-gerrit.ics.uci.edu/#/c/1148/4/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java:

Line 77:                 //how is this right?????????? <needs to be fixed>
Please file an Issue. Rarely do we remember comments in the code.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1148
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message