asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Expose Asterix Configuration on Cluster Servlet
Date Thu, 08 Sep 2016 03:47:37 GMT
Michael Blow has posted comments on this change.

Change subject: Expose Asterix Configuration on Cluster Servlet
......................................................................


Patch Set 1:

(3 comments)

Tests added.

https://asterix-gerrit.ics.uci.edu/#/c/1153/1/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixReplicationProperties.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixReplicationProperties.java:

Line 198:     @PropertyKey("replication.factor")
> Introduce a constant?
Done


Line 209:     @PropertyKey("replication.timeout")
> Introduce a constant?
Done


Line 260:     @PropertyKey("replication.max.remote.recovery.attempts")
> Introduce a constant?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1153
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I828d6a61afe615f7826079ede4b1d638bbd7ac5d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message