asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Extend Cluster API Servlet, += Config / Stats
Date Wed, 07 Sep 2016 05:39:22 GMT
Till Westmann has posted comments on this change.

Change subject: Extend Cluster API Servlet, += Config / Stats
......................................................................


Patch Set 3:

(5 comments)

Looks good, just a question wrt the HTTP status code that gets returned, if the URI does not
identify a valid resource.

https://asterix-gerrit.ics.uci.edu/#/c/1147/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java:

Line 73:             throw new IllegalArgumentException();
Shouldn't we just get a 404 here, ff the path (URL) is not valid?


Line 88:             throw new IllegalArgumentException("unknown nc: " + node);
Same here?


Line 100:                 throw new IllegalArgumentException();
Or here?


Line 125:             throw new IllegalArgumentException("unknown nc: " + node);
Or here?


https://asterix-gerrit.ics.uci.edu/#/c/1147/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:

Line 76: import static org.apache.asterix.api.http.servlet.ServletConstants.HYRACKS_CONNECTION_ATTR;
Wow, these sure seem to be moving around :)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1147
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message