asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Access To Node Configuration & Statistics
Date Tue, 06 Sep 2016 21:49:45 GMT
Michael Blow has posted comments on this change.

Change subject: Access To Node Configuration & Statistics
......................................................................


Patch Set 1:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1147/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:

Line 242:         ServletMapping mapping = new ServletMapping();
> What does this add?
This enables a servlet to be mapped to multiple paths.


https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java:

Line 34: import org.json.JSONObject;
> Would be nice not to have a dependency on JSONObject in this interface.
Done


Line 197:      *@param includeConfig @return {@link JSONObject} containing the node details
> WS
Done


Line 200:     public String getNodeDetailsJSON(String nodeId, boolean includeStats, boolean
includeConfig) throws Exception;
> It seems that we don't use this method. Do we need to expose it on the Hyra
The next patch will introduce a usage, sorry.


https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java:

Line 59:     public String getNodeDetailsJSON(String nodeId, boolean includeStats, boolean
includeConfig) throws Exception;
> This also seems to be unused.
The next patch will introduce a usage, sorry.


https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java:

Line 291:         if (includeConfig) {
> How do I access add this information from the HTTP API? Do we have docs/a t
Is the existing HTTP API documented somewhere?  I can update that.  A test is forthcoming.


https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java:

Line 56:             detail = ncs.toDetailedJSON(includeStats, includeConfig);
> Conditional expression?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1147
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message