asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Hillery (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Depend on asterix-opt-bom 1.0.0-SNAPSHOT
Date Fri, 02 Sep 2016 05:04:11 GMT
Chris Hillery has posted comments on this change.

Change subject: Depend on asterix-opt-bom 1.0.0-SNAPSHOT
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1137/1/asterixdb/asterix-server/pom.xml
File asterixdb/asterix-server/pom.xml:

Line 179:           <version>1.0.0-SNAPSHOT</version>
> I think this should match the asterixdb version (i.e. ${project.version})
It can be anything we want. I'd almost prefer for it to be a never-changing constant, and
1.0.0 seems like a reasonable constant to pick. But if you think it makes sense to use the
asterixdb version, that's fine too I guess. It means we need to update asterix-opt whenever
we bump the asterixdb version, but I suppose we'll need to anyway.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1137
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5b95bc052c87419d0e925e46f7741b97cc1132
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message