Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0FB28200B80 for ; Wed, 31 Aug 2016 07:24:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0E15D160AC5; Wed, 31 Aug 2016 05:24:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 565A2160ABA for ; Wed, 31 Aug 2016 07:24:49 +0200 (CEST) Received: (qmail 34405 invoked by uid 500); 31 Aug 2016 05:24:48 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 34396 invoked by uid 99); 31 Aug 2016 05:24:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2016 05:24:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 030331A92B0 for ; Wed, 31 Aug 2016 05:24:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id M75pQG17JJRw for ; Wed, 31 Aug 2016 05:24:46 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id ECF0E5FACE for ; Wed, 31 Aug 2016 05:24:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 8E4B9241DEB; Tue, 30 Aug 2016 22:24:38 -0700 (PDT) Date: Tue, 30 Aug 2016 22:24:38 -0700 From: "Till Westmann (Code Review)" To: Michael Blow CC: Jenkins Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs X-Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7 X-Gerrit-ChangeURL: X-Gerrit-Commit: eb945f14fd83bb42bcdb53562ef7d87984b23798 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160831052438.8E4B9241DEB@unhygienix.ics.uci.edu> archived-at: Wed, 31 Aug 2016 05:24:50 -0000 Till Westmann has posted comments on this change. Change subject: Add Helper Client To Interface With Cluster HTTP APIs ...................................................................... Patch Set 9: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java: Line 95: public abstract int execute(); Should we have this one throw an IOException and save some exception wrapping in the subclasses? https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/GetClusterStateCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/GetClusterStateCommand.java: Line 50: // TODO (mblow): interrogate result to determine cluster readiness, not rely on HTTP 200 That'd be nice - I'm not sure that the codes are reliable https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ShutdownCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ShutdownCommand.java: Line 53: // TODO (mblow): interrogate result to determine acceptance, not rely on HTTP 200 That'd be nice - I'm not sure that the codes are reliable. However, I'm also not sure if the shutdown servlet returns something useful ... https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.sh File asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.sh: Line 19: # reserved. s/2006/2016/ ? Or remove the copyright and put the "normal" header? https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.sh File asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.sh: Line 19: # reserved. s/2006/2016/ ? Or remove the copyright and put the "normal" header? Line 49: echo " wait for CCDriver to terminate if running." only one space between echo and " -- To view, visit https://asterix-gerrit.ics.uci.edu/1126 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes