Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 67683200B63 for ; Mon, 15 Aug 2016 23:58:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 65E88160AA7; Mon, 15 Aug 2016 21:58:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AACA7160A8A for ; Mon, 15 Aug 2016 23:58:47 +0200 (CEST) Received: (qmail 72799 invoked by uid 500); 15 Aug 2016 21:58:46 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 72790 invoked by uid 99); 15 Aug 2016 21:58:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 21:58:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 83960180666 for ; Mon, 15 Aug 2016 21:58:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id T0SXpOh7vdkV for ; Mon, 15 Aug 2016 21:58:44 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8D0D95F2F2 for ; Mon, 15 Aug 2016 21:58:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 46A99241DA8; Mon, 15 Aug 2016 14:58:44 -0700 (PDT) Date: Mon, 15 Aug 2016 14:58:44 -0700 From: "Till Westmann (Code Review)" To: Yingyi Bu CC: Jenkins Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: ASTERIXDB-1571: fix and add regression tests. X-Gerrit-Change-Id: I45d6dbabdef709c9ba3cb883412301ab7fd69a85 X-Gerrit-ChangeURL: X-Gerrit-Commit: 22a7443a8524f7863c19ec383c7402a249fe9602 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160815215844.46A99241DA8@unhygienix.ics.uci.edu> archived-at: Mon, 15 Aug 2016 21:58:48 -0000 Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1571: fix and add regression tests. ...................................................................... Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1075/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java: Line 133: if(projection.star()){ spaces? https://asterix-gerrit.ics.uci.edu/#/c/1075/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppFormatPrintVisitor.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppFormatPrintVisitor.java: Line 132: if(projection.star()){ spaces? https://asterix-gerrit.ics.uci.edu/#/c/1075/3/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/TypePropagationPolicy.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/TypePropagationPolicy.java: Line 72: // and investigate why many test queries fail if only live variables' types are propagated. Did you file an issue? -- To view, visit https://asterix-gerrit.ics.uci.edu/1075 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45d6dbabdef709c9ba3cb883412301ab7fd69a85 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes