asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Log exception on managix failure
Date Tue, 16 Aug 2016 01:49:31 GMT
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1080

Change subject: Log exception on managix failure
......................................................................

Log exception on managix failure

Change-Id: I108be36c531ddceebf976e7cbe44e957ef2b7340
---
M asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/driver/InstallerDriver.java
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/80/1080/1

diff --git a/asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/driver/InstallerDriver.java
b/asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/driver/InstallerDriver.java
index 61e7916..00648be 100644
--- a/asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/driver/InstallerDriver.java
+++ b/asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/driver/InstallerDriver.java
@@ -23,14 +23,13 @@
 import javax.xml.bind.JAXBContext;
 import javax.xml.bind.Unmarshaller;
 
-import org.apache.log4j.Logger;
-
 import org.apache.asterix.event.service.AsterixEventService;
 import org.apache.asterix.event.service.ILookupService;
 import org.apache.asterix.event.service.ServiceProvider;
 import org.apache.asterix.installer.command.CommandHandler;
 import org.apache.asterix.installer.command.ConfigureCommand;
 import org.apache.asterix.installer.schema.conf.Configuration;
+import org.apache.log4j.Logger;
 
 public class InstallerDriver {
 
@@ -96,10 +95,11 @@
             LOGGER.error("Unknown command");
             printUsage();
         } catch (Exception e) {
-            LOGGER.error(e.getMessage());
             if (e.getMessage() == null || e.getMessage().length() < 10) {
                 // less than 10 characters of error message is probably not enough
-                e.printStackTrace();
+                LOGGER.error(e.toString(), e);
+            } else {
+                LOGGER.error(e.getMessage(), e);
             }
         }
     }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1080
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I108be36c531ddceebf976e7cbe44e957ef2b7340
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>

Mime
View raw message