asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Change to create syntax for open indices - both for AQL and ...
Date Tue, 23 Aug 2016 18:26:54 GMT
Till Westmann has posted comments on this change.

Change subject: Change to create syntax for open indices - both for AQL and SQLPP.
......................................................................


Patch Set 1:

(2 comments)

2 small comments on the commit message and AQL.jj. Also, it would be nice to add a negative
test.

https://asterix-gerrit.ics.uci.edu/#/c/1106/1//COMMIT_MSG
Commit Message:

Line 21:     making optionality non-optional when creating an open index, part 1
We prefer to have a single commit message that describes the change in it entirety and does
not contain information about the intermediate commits on your local repository. The only
thing that needs to be kept in the message is the Change-Id on the bottom as that is Gerrit's
identifier for this review.

Some rules for the formatting of commit messages are at 
https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting


https://asterix-gerrit.ics.uci.edu/#/c/1106/1/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
File asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj:

Line 1418:   ( <COLON> fieldType =  IndexedTypeExpr() <QUES>)?{
For some (historical) reason in jj files we keep the opening brace on a it's own line.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1106
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32bf8bc5ac1c0e6aa6744ca8f91a197311219814
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message