asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add Asterix Extension Manager
Date Fri, 12 Aug 2016 10:37:49 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Add Asterix Extension Manager
......................................................................


Patch Set 10:

@Yingyi, I will go over the inner comments but want to respond to the two outer comments here:

1. insertion for dataset with meta is still not allowed. but I moved the decision from the
method in LangExpressionToPlanTranslator to the implementation of the dataset. Say someone
wants to extend the dataset with a dataset that has meta and allows upsert for some cases,
this enable the extension to basically have the decision in their implementation of the dataset
object.

2. the copy and setOperatorId are needed if one wants to take operators from a compiled job
and use them in a newly created job. For example, the new feed implementation will make use
of these since it will combine a list of jobs into a single job. Otherwise, the activity id
will not be updated which would lead to many runtime errors.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1017
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I280268495cc3aad00f898cba21f7299f7120ce5c
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message