asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Carey (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1528: fix 101 query 6 and 7.
Date Thu, 11 Aug 2016 20:56:47 GMT
Michael Carey has posted comments on this change.

Change subject: ASTERIXDB-1528: fix 101 query 6 and 7.
......................................................................


Patch Set 3:

(2 comments)

Just looked at this - suggested a very small wording change as well as an optional additional
sentence.  Same comment applies to both.

https://asterix-gerrit.ics.uci.edu/#/c/1063/3/asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md
File asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md:

Line 692:         select $fbu;
I think the wording "no records that miss" would be better said via "no records with missing"
-- English-wise.  (It's not wrong, just awkward, as it currently is.)  Thx!  For extra credit,
we could also take this opportunity to mention that another formulation could be is-unknown.
 Maybe something like "Another way to test the employment condition could be to use the is-unknown(.)
function instead of is-missing; that approach would also allow for the case where $e.end-date
is present but null-valued."


https://asterix-gerrit.ics.uci.edu/#/c/1063/3/asterixdb/asterix-doc/src/site/markdown/aql/primer.md
File asterixdb/asterix-doc/src/site/markdown/aql/primer.md:

Line 690: 
Same comment here.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1063
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35bbf838b152bdfd56efd523961ec1dc0ca8322d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message