Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 365A6200B4C for ; Fri, 22 Jul 2016 20:42:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 35057160A6D; Fri, 22 Jul 2016 18:42:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7F712160A5A for ; Fri, 22 Jul 2016 20:42:43 +0200 (CEST) Received: (qmail 40637 invoked by uid 500); 22 Jul 2016 18:42:42 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 40628 invoked by uid 99); 22 Jul 2016 18:42:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jul 2016 18:42:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 589AAC3432 for ; Fri, 22 Jul 2016 18:42:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.126 X-Spam-Level: ** X-Spam-Status: No, score=2.126 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kP9yMJGFP20S for ; Fri, 22 Jul 2016 18:42:40 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 04D8E60E6D for ; Fri, 22 Jul 2016 18:42:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 64A86242063; Fri, 22 Jul 2016 11:42:39 -0700 (PDT) Date: Fri, 22 Jul 2016 11:42:39 -0700 From: "abdullah alamoudi (Code Review)" CC: Till Westmann , Jenkins , Michael Blow Reply-To: bamousaa@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Add Maven Plugin for Grammar Extension X-Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad X-Gerrit-ChangeURL: X-Gerrit-Commit: e65f45a143b5d51eb6873836039f32d53f3ee6f4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160722184239.64A86242063@unhygienix.ics.uci.edu> archived-at: Fri, 22 Jul 2016 18:42:44 -0000 abdullah alamoudi has posted comments on this change. Change subject: Add Maven Plugin for Grammar Extension ...................................................................... Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/src/main/java/org/apache/asterix/lang/extension/EchoStatement.java File asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/src/main/java/org/apache/asterix/lang/extension/EchoStatement.java: Line 40: return -0x01; > I think -1 or 0xFF, but mixing negative and hex just seems evil. It's a te -1 it is. 0x80 - 0xFF all give compilation error -- To view, visit https://asterix-gerrit.ics.uci.edu/1011 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes