Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 80019200B55 for ; Sun, 17 Jul 2016 04:26:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7E8E7160A7C; Sun, 17 Jul 2016 02:26:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C6B8D160A6C for ; Sun, 17 Jul 2016 04:26:08 +0200 (CEST) Received: (qmail 9308 invoked by uid 500); 17 Jul 2016 02:26:08 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 9299 invoked by uid 99); 17 Jul 2016 02:26:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 Jul 2016 02:26:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7776CC207E for ; Sun, 17 Jul 2016 02:26:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id LrPSvQTVSn33 for ; Sun, 17 Jul 2016 02:26:05 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B8B595F1F3 for ; Sun, 17 Jul 2016 02:26:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id CD5CE241EC6; Sat, 16 Jul 2016 19:26:03 -0700 (PDT) Date: Sat, 16 Jul 2016 19:26:03 -0700 From: "Till Westmann (Code Review)" To: Preston Carman CC: Jenkins , Yingyi Bu Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Sonar fixes and other clean up items. X-Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818 X-Gerrit-ChangeURL: X-Gerrit-Commit: 59738ef5706c7b4c7692626d0a8852a60d46936f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160717022603.CD5CE241EC6@unhygienix.ics.uci.edu> archived-at: Sun, 17 Jul 2016 02:26:09 -0000 Till Westmann has posted comments on this change. Change subject: Sonar fixes and other clean up items. ...................................................................... Patch Set 6: Code-Review+2 (3 comments) I found 3 more and are not really problematic. Feel free to forward the +2, if you decide to address them. https://asterix-gerrit.ics.uci.edu/#/c/999/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java: Line 168: } catch (HyracksDataException e) { I think that we can remove this try-catch. Line 189: } catch (HyracksDataException e) { I think that we can remove this try-catch. https://asterix-gerrit.ics.uci.edu/#/c/999/6/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java: Line 62: private final Map>> metaAsterixOpSkeletons = new HashMap<>(); > MAJOR SonarQube violation: Would be nice to fix this. -- To view, visit https://asterix-gerrit.ics.uci.edu/999 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes