asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Implement EXPLAIN for SQL++
Date Thu, 28 Jul 2016 01:22:29 GMT
Till Westmann has posted comments on this change.

Change subject: Implement EXPLAIN for SQL++
......................................................................


Patch Set 4:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1020/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java:

Line 51:     private boolean wrap_array = false;
> camel case convention?
Done


Line 53:     private boolean notfirst = false;
> camel case convention?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1020/4/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java:

Line 32:     private boolean explain = false;
> make that part of the constructor so that we can set that right in visitors
Done


Line 109:     public int hashCode() {
> make "explain" part of the hash code calculation?
Done


Line 120:         }
> make "explain" part of the equality check?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1020
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message