asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Refactor Metadata Record Types
Date Thu, 28 Jul 2016 01:21:49 GMT
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/1031

to look at the new patch set (#2).

Change subject: Refactor Metadata Record Types
......................................................................

Refactor Metadata Record Types

The change cleans up Metadata Record Types in the following ways:
1. Gets rid of unneeded throws clauses.
2. Gets rid of the need to explicitly calls init and instead
all members become static final.
3. Gets rid of all the unneeded scattered methods for creating
the different type. They get replaced by a single method for
creating a record type that is safe (doesn't throw exception)
and makes it clear what the requested type is.
4. Replaced all the scattered strings with constants that makes
maintaining them easy and eliminates the chance of misspelling
of a field name since they can be accessed whenever needed from
a single location.
5. ensures no two fields share a variable. this fixes a bug and
the wrong expected result was fixed.

Note: SonarQube had created tens of warnings for this class.
all of them were fixed and no more warning show up

Change-Id: I10bc8c0bc255a377dba724f04b6b588910f26cb2
---
M asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataRecordTypes.java
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java
M asterixdb/asterix-metadata/src/test/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslatorTest.java
M asterixdb/asterix-metadata/src/test/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslatorTest.java
6 files changed, 454 insertions(+), 426 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/31/1031/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I10bc8c0bc255a377dba724f04b6b588910f26cb2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>

Mime
View raw message