asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Support CASE expression in SQL++.
Date Tue, 26 Jul 2016 02:17:32 GMT
Till Westmann has posted comments on this change.

Change subject: Support CASE expression in SQL++.
......................................................................


Patch Set 16: Code-Review+2

(2 comments)

Feel free to forward the +2 if you decide to address the comment in AbstractTypeCheckEvaluator.

https://asterix-gerrit.ics.uci.edu/#/c/1015/16/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/AbstractTypeCheckEvaluator.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/AbstractTypeCheckEvaluator.java:

Line 37:     protected enum VALUE {
Why is this ALL_CAPS? Don't we usually use the same rules for enum names as for class names?


https://asterix-gerrit.ics.uci.edu/#/c/1015/16/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/formats/NonTaggedDataFormat.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/formats/NonTaggedDataFormat.java:

Line 452:                 PA.invokeMethod(fd, "reset(org.apache.asterix.om.types.IAType, org.apache.asterix.om.types.IAType)",
rt,
What is the cost of finding a "cleaner" solution than PA.invokeMethod? It's just a question,
I know that there are many other uses as well.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1015
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9de7c3df70be43456e38a61ce767cc14f09e661
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message