asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add Maven Plugin for Grammar Extension
Date Fri, 22 Jul 2016 18:42:39 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Add Maven Plugin for Grammar Extension
......................................................................


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1011/2/asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/src/main/java/org/apache/asterix/lang/extension/EchoStatement.java
File asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/src/main/java/org/apache/asterix/lang/extension/EchoStatement.java:

Line 40:         return -0x01;
> I think -1 or 0xFF, but mixing negative and hex just seems evil.  It's a te
-1 it is.
0x80 - 0xFF all give compilation error


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1011
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2d11782d43dd8f27d69e347ed0fc8797d79dad
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message