asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1536: supports fully qualified dataset path in SQL++.
Date Wed, 20 Jul 2016 22:31:56 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1536: supports fully qualified dataset path in SQL++.
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Looks good to me. Maybe we could add a test case for the ambiguous case in SQL++ (if it's
not there and I've missed it ..)?

https://asterix-gerrit.ics.uci.edu/#/c/1008/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java
File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java:

Line 116:                     + (dataverseName == null ? metadataProvider.getDefaultDataverseName()
: dataverseName)
Maybe we can pull this out into a variable, so we don't do it once for the check and once
for the error message?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1008
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93c7187b3a363a82dbfa225eb67ab526e04aa2dd
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message