asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <>
Subject Change in asterixdb[master]: Add Test NodeController, Test Data Generator, and Marker Logs
Date Tue, 19 Jul 2016 06:19:00 GMT
Till Westmann has posted comments on this change.

Change subject: Add Test NodeController, Test Data Generator, and Marker Logs

Patch Set 10:

File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/

Line 89:             logRecord = new LogRecord(callback);
This is a nice improvement.
File asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/

Line 275:                 AsterixRuntimeComponentsProvider.RUNTIME_PROVIDER, LSMBTreeIOOperationCallbackFactory.INSTANCE,
What is the meaning of "0.01"? Could we have a symbolic name?

Line 288:                 AsterixRuntimeComponentsProvider.RUNTIME_PROVIDER, LSMBTreeIOOperationCallbackFactory.INSTANCE,
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/

Line 49:     // we already have an index field!! should we add another pointer to the same
Could you elaborate more on the comment?
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/

Line 134:         switch (logType) {
Much better with the switch.
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/

Line 220:                             // TODO (amoudi): find a better reactive way to do this
It might be helpful to add a JIRA issue for yourself for this that describes the problem and
the desired properties of the solution.
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/

Line 48:     public void set(String key, Object value);
I'm confused about this interface change. The idea of the shared object was that every Hyracks
application could define a typed object that could be stored in the context, such that only
one cast is necessary - to the class of the typed object - and then regular accessors could
be used. Why doesn't that work here (and why do we need to change this interface)?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9aa8de758b7d26ca34868b16e5ce693e0c0243
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Michael Blow <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message