asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Sonar fixes and other clean up items.
Date Sun, 17 Jul 2016 02:26:03 GMT
Till Westmann has posted comments on this change.

Change subject: Sonar fixes and other clean up items.
......................................................................


Patch Set 6: Code-Review+2

(3 comments)

I found 3 more and are not really problematic.
Feel free to forward the +2, if you decide to address them.

https://asterix-gerrit.ics.uci.edu/#/c/999/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java:

Line 168:         } catch (HyracksDataException e) {
I think that we can remove this try-catch.


Line 189:             } catch (HyracksDataException e) {
I think that we can remove this try-catch.


https://asterix-gerrit.ics.uci.edu/#/c/999/6/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java
File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java:

Line 62:     private final Map<Integer, List<Pair<IPushRuntimeFactory, RecordDescriptor>>>
metaAsterixOpSkeletons = new HashMap<>();
> MAJOR SonarQube violation:
Would be nice to fix this.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb72a0fef3c181282cc4c71b881a7cb52da86818
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message