asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: add error code and string formatting to exception
Date Fri, 15 Jul 2016 18:39:54 GMT
Till Westmann has posted comments on this change.

Change subject: add error code and string formatting to exception
......................................................................


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1000/5/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java:

Line 104:             msgCache = formatMessage(component, errorCode, super.getMessage(), params);
> If multiple threads access getMessage() for a particular exception instance
Yes, it should. The other question I had, was if it is good to have it. Formatting the message
is somewhat expensive, but I'm not sure how much that matters ...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1000
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83941719c6ee0a5a2ce7337b328ad094116fd13f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message