asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Support SQL-compliant group-by syntax.
Date Wed, 13 Jul 2016 21:17:18 GMT
Till Westmann has posted comments on this change.

Change subject: Support SQL-compliant group-by syntax.
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

Just one question.

https://asterix-gerrit.ics.uci.edu/#/c/990/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/ExpressionToVariableUtil.java
File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/ExpressionToVariableUtil.java:

Line 42:             return null;
This seems to introduce the need for a number of null checks (and potential NPEs if we miss
one). Would it make sense to introduce a special singleton? Or would that just replace all
null checks with other checks?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/990
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1cbe1fab216b5f47577d75fd870a537cfe1e84f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message